Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rules_test.py #499

Merged
merged 4 commits into from
Oct 8, 2021
Merged

fix rules_test.py #499

merged 4 commits into from
Oct 8, 2021

Conversation

nsano-rururu
Copy link
Collaborator

@nsano-rururu nsano-rururu commented Oct 7, 2021 •
edited
Loading

Description

I modified the modified test code in the pull request below.
#483

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

Questions or Comments

@jertel jertel mentioned this pull request Oct 8, 2021
Merged
4 tasks
jertel
jertel approved these changes Oct 8, 2021
View reviewed changes
Copy link
Owner

@jertel jertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the continual unit test improvements.

@jertel jertel merged commit f56cfd8 into jertel:master Oct 8, 2021
@nsano-rururu nsano-rururu deleted the fix_testcode branch October 8, 2021 15:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jertel jertel jertel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nsano-rururu @jertel