Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not install the tests with pip install #733

Merged
merged 2 commits into from
Feb 23, 2022
Merged

do not install the tests with pip install #733

merged 2 commits into from
Feb 23, 2022

Conversation

buzzdeee
Copy link
Contributor

@buzzdeee buzzdeee commented Feb 22, 2022 •
edited
Loading

Description

Installing elastalert2 via pip also installs the tests subdirectory, which clutters up the system.

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

Questions or Comments

@nsano-rururu
Copy link
Collaborator

nsano-rururu commented Feb 23, 2022 •
edited
Loading

The description of changelog is incorrect.

- Do not install tests via pip install [#733] - @buzzdeee

　　　　↓
　　　　

- Do not install tests via pip install [#733](https://github.com/jertel/elastalert2/pull/733) - @buzzdeee

@buzzdeee
Copy link
Contributor Author

yikes, I copied the CHANGELOG entry from the one before, updated both

jertel
jertel approved these changes Feb 23, 2022
View reviewed changes
Copy link
Owner

@jertel jertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this and submitting the PR!

@jertel jertel merged commit 6f110a0 into jertel:master Feb 23, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jertel jertel jertel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@buzzdeee @nsano-rururu @jertel