-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] support prometheus-operator serviceMonitor and prometeusRules #902
Conversation
… 'metrics' variable. Add support for prometheus-operator custom resources: prometheusrules and servicemonitor. Chart labels updated to reflect helm recommended labelset.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this. Please take a look at the README.md descriptions -- I spotted several typos on the new field descriptions. I'll leave it open for a few days to let others comment, since, as you said, it will impact existing chart users.
Hi, file updated. I have a question thought, |
It's fine with me if you'd like to mention in the chart's README.md where you found the inspiration for the new tagging structure. There are still some typos on the README field descriptions (like merics instead of metrics, aply instead of apply and when detected when detected). If you don't get around to fixing them I'll make some edits later this week as time allows. |
Please correct the checklist in this PR. There are slashes instead of x's and it makes it difficult to understand which checklist items you are marking as completed. Use an |
@jertel when will be available the new release? This feature's really useful. |
The current plan is this weekend. |
Description
This enables exposing elastalert2 using the 'metrics' configuration section of the Chart. It also supports creating both serviceMonitor and prometheusRules custom resources for prometheus-operator to be able to automacitally detect and reconfigure prometheus accordingly.
Breaking change:
Checklist
make test-docker
with my changes.Questions or Comments
no manual tests included for the chart. It has been deployed through helm_install without issues.