Make URLs in confirmation panels clickable, and underline them

[stefanhaller]

• PR Description

This is especially helpful for the breaking changes popup, which has a link to the release notes, but it could also be useful for other panels that display some warning or error with a link to more information.

• Please check if the PR fulfills these requirements

• Cheatsheets are up-to-date (run go generate ./...)
• Code has been formatted (see here)
• Tests have been added/updated (see here for the integration test guide)
• Text is internationalised (see here)
• Docs (specifically docs/Config.md) have been updated if necessary
• You've read through your own file changes for silly mistakes etc

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ -0.04% (target: -2.00%)	✅ 54.90%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (1cedfa4)	50365	42372	84.13%
Head commit (5d509ef)	50405 (+40)	42388 (+16)	84.09% (-0.04%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#3446)	51	28	54.90%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation}

[stefanhaller]

This is pretty hacky, but we need it so that we don't cancel the bold text. I don't see a better way of doing this except by making changes to gookit/color.

[jesseduffield]

Thoughts on using tcell's terminal hyperlinks ability? gdamore/tcell#300

[stefanhaller]

I had no idea this existed. I'll play with this to see if it's useful for our case.

[stefanhaller]

So I'm not very thrilled by tcell's hyperlinks. I couldn't get it to work in Terminal.app, only in iTerm2 (but I may well have done something wrong). In general it's a bit unclear to me how widely supported the feature is yet.

Also, you have to hold down Command while clicking them (ctrl on Windows), which I find inconvenient, and hard to discover. I would prefer them to behave more like links on a web page; just click them.

Finally, it would take some effort to make this available in gocui, it's actually not quite clear to me how to design the APIs. There's plenty of code that just passes around fg and bg Attributes to functions (and those are enums); but we need to pass attached data for this one. It would take a while to add this to the current design of how attributes work in gocui.

To sum it up, I'd prefer to stick with the more pedestrian approach I'm taking here.

[jesseduffield]

Makes sense, LGTM

[dandavison]

So I'm not very thrilled by tcell's hyperlinks.

Hi @stefanhaller, FWIW, I opened #3817 to make a case for adding OSC hyperlink support! Personally I find being able to click on a line number in a diff to open my editor at that line to be really valuable. Hyperlinks are supported by many terminal emulators, and tmux.

Also, you have to hold down Command while clicking them (ctrl on Windows), which I find inconvenient, and hard to discover.

But, I think that is how people click links in a lot of terminal emulators (i.e. raw URLs, without the OSC8 sequences).

[stefanhaller]

Hi @stefanhaller, FWIW, I opened #3817 to make a case for adding OSC hyperlink support!

OK, but that's two different things now:

1. support for simply forwarding OSC hyperlinks emitted from a pager to the tcell layer (right now they are filtered out by gocui)
2. support for emitting OSC hyperlinks ourselves through application APIs, e.g. for implementing the links in lazygit's status page or in confirmation panels.

I'm all for doing 1.; being able to get the hyperlinks from delta --hyperlinks working would be really cool. I'll see if can make this work next week, it doesn't sound very hard to me.

I'm still skeptical about 2. though, and would continue to use the manual approach that we have in lazygit right now; mainly because it works in all terminals, and is more discoverable.

BTW, I'm a huge fan of delta, thanks for this awesome tool!

[dandavison]

I'm all for doing 1.; being able to get the hyperlinks from delta --hyperlinks working would be really cool. I'll see if can make this work next week, it doesn't sound very hard to me.

Wow, that would be amazing! Thanks for looking into this.

I'm still skeptical about 2. though, and would continue to use the manual approach that we have in lazygit right now; mainly because it works in all terminals, and is more discoverable.

Absolutely, I certainly don't have a strong opinion about that. Maybe it will even make UX sense for there to be a distinction between "native" links (direct click) and links deriving from 3rd-party pagers (command/ctrl click).

BTW, I'm a huge fan of delta, thanks for this awesome tool!

Thanks! lazygit is fantastic and I'd love to make the experience of using delta with lazygit as good as possible. Don't hesitate to send bugs/feature requests our way (also my email address is in my GitHub profile page).