-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support pushing multiple results to success handler #65
base: master
Are you sure you want to change the base?
Conversation
@dcsim0n I was making a few small changes to the example and realized the success handler isn't supporting multiple results - I took a pass at fixing that and wondered if you'd be willing to have a look at what I came up with? |
of course these changes would require a major version bump, which is fine by me |
another thought: we could instead drop support for multiple results and change the api so it's up to the user if they want to return an array? |
My first suggestion is something like this
I understand this would break the current api by reversing the order that the job is passed, but it does make for an elegant implementation. The Rest operator syntax only exists for ES6 and up, not sure if that breaks anything for you. |
good point, that is a little cleaner. will add a patch to try it when i get a chance, thanks. |
No description provided.