refactor(max-nested-describe): simplify implementation (#1442)

jest-community · Sep 29, 2023 · 1ee0087 · 1ee0087
1 parent c846f7f
commit 1ee0087
Showing 1 changed file with 20 additions and 42 deletions.
diff --git a/src/rules/max-nested-describe.ts b/src/rules/max-nested-describe.ts
@@ -1,4 +1,4 @@
-import { AST_NODE_TYPES, type TSESTree } from '@typescript-eslint/utils';
+import type { TSESTree } from '@typescript-eslint/utils';
 import { createRule, isTypeOfJestFnCall } from './utils';
 
 export default createRule({
@@ -29,49 +29,27 @@ export default createRule({
   },
   defaultOptions: [{ max: 5 }],
   create(context, [{ max }]) {
-    const describeCallbackStack: number[] = [];
-
-    function pushDescribeCallback(
-      node: TSESTree.ArrowFunctionExpression | TSESTree.FunctionExpression,
-    ) {
-      const { parent } = node;
-
-      if (
-        parent?.type !== AST_NODE_TYPES.CallExpression ||
-        !isTypeOfJestFnCall(parent, context, ['describe'])
-      ) {
-        return;
-      }
-
-      describeCallbackStack.push(0);
-
-      if (describeCallbackStack.length > max) {
-        context.report({
-          node: parent,
-          messageId: 'exceededMaxDepth',
-          data: { depth: describeCallbackStack.length, max },
-        });
-      }
-    }
-
-    function popDescribeCallback(
-      node: TSESTree.ArrowFunctionExpression | TSESTree.FunctionExpression,
-    ) {
-      const { parent } = node;
-
-      if (
-        parent?.type === AST_NODE_TYPES.CallExpression &&
-        isTypeOfJestFnCall(parent, context, ['describe'])
-      ) {
-        describeCallbackStack.pop();
-      }
-    }
+    const describes: TSESTree.CallExpression[] = [];
 
     return {
-      FunctionExpression: pushDescribeCallback,
-      'FunctionExpression:exit': popDescribeCallback,
-      ArrowFunctionExpression: pushDescribeCallback,
-      'ArrowFunctionExpression:exit': popDescribeCallback,
+      CallExpression(node) {
+        if (isTypeOfJestFnCall(node, context, ['describe'])) {
+          describes.unshift(node);
+
+          if (describes.length > max) {
+            context.report({
+              node,
+              messageId: 'exceededMaxDepth',
+              data: { depth: describes.length, max },
+            });
+          }
+        }
+      },
+      'CallExpression:exit'(node) {
+        if (describes[0] === node) {
+          describes.shift();
+        }
+      },
     };
   },
 });