Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix displayName object configuration #8

Merged
merged 2 commits into from
Jun 25, 2019

Conversation

jeysal
Copy link
Member

@jeysal jeysal commented Jun 17, 2019

jestjs/jest#8025 added the possibility to specify the the displayName as {name: string, color: string}. Using this format caused jest-watch-select-projects to show [object Object]. This PR makes sure that the new format is handled correctly.
Tested on a Jest multi-project setup including projects configured with both string and object displayNames.
I've also had to add a prettier configuration matching the existing code so that there are no unrelated formatting changes to index.js

@jeysal jeysal changed the title Displayname object fix displayName object configuration Jun 17, 2019
@jeysal
Copy link
Member Author

jeysal commented Jun 20, 2019

ping @rogeliog ICYMI :)

@rogeliog rogeliog self-assigned this Jun 25, 2019
@rogeliog rogeliog merged commit f87a76c into jest-community:master Jun 25, 2019
@rogeliog
Copy link
Member

Sorry for the late response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants