Implement toMatchDiffSnapshot jest matcher.
#11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
Aug 10, 2017
src/index.js
Outdated
| @@ -64,4 +65,12 @@ function diffReactComponents(valueA: any, valueB: any, options: Options) { | |||
| }); | |||
| } | |||
|
|
|||
| function toMatchDiffSnapshot(valueA: any, valueB: any, options: Options) { | |||
thymikee
reviewed
Aug 10, 2017
| interface Matchers { | ||
| toMatchDiffSnapshot(valueB: any, options?: DiffOptions): boolean | ||
| } | ||
| } |
thymikee
reviewed
Aug 10, 2017
| @@ -0,0 +1,13 @@ | |||
| /// <reference types="jest"/> | |||
There was a problem hiding this comment.
I'm not sure. I took jest-immutable-matchers/index.d.ts as an example cause it was working without any configuration with my IDE.
There was a problem hiding this comment.
It's still in docs
thymikee
reviewed
Aug 10, 2017
| expect.extend({ toMatchDiffSnapshot: snapshotDiff.toMatchDiffSnapshot }); | ||
| }); | ||
|
|
||
| test('foo', () => { |
There was a problem hiding this comment.
test('works with default options', () => {})
thymikee
requested changes
Aug 10, 2017
thymikee
reviewed
Aug 10, 2017
|
|
||
| test('works with default options', () => { | ||
| expect(a).toMatchDiffSnapshot(b); | ||
| }); |
There was a problem hiding this comment.
Can you also make Flow happy? I'm fine with adding // $FlowFixMe here for now
thymikee
approved these changes
Aug 10, 2017
|
Thank you for your hard work @umidbekkarimov ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #10