Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix when "update snapshots" message is displayed #trivial #356

Merged
merged 1 commit into from
Jul 30, 2018
Merged

Fix when "update snapshots" message is displayed #trivial #356

merged 1 commit into from
Jul 30, 2018

Conversation

chrismcleod
Copy link
Contributor

The existing check was not working in [email protected]

@coveralls
Copy link

coveralls commented Jul 28, 2018

Pull Request Test Coverage Report for Build 425

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.1%) to 84.007%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/JestExt.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 418: 2.1%
Covered Lines: 690
Relevant Lines: 806

💛 - Coveralls

@chrismcleod chrismcleod changed the title Fix when "update snapshots" message is displayed Fix when "update snapshots" message is displayed #trivial Jul 28, 2018
@chrismcleod chrismcleod changed the title Fix when "update snapshots" message is displayed #trivial Fix when "update snapshots" message is displayed Jul 28, 2018
@chrismcleod chrismcleod changed the title Fix when "update snapshots" message is displayed Fix when "update snapshots" message is displayed #trivial Jul 28, 2018
Copy link
Collaborator

@connectdotz connectdotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch 👍

This area doesn't have much test coverage, want to take this opportunity to add an unit test? At least for the new pattern if not the whole handler...

@chrismcleod
Copy link
Contributor Author

I can definitely test the regex. I took about 30 mins to try and figure out how to test that a notification is shown by a vscode extension. I have never developed one myself however, and didn't get very far. Any ideas or links with some information about how to test that?

@chrismcleod
Copy link
Contributor Author

@connectdotz I added at least one test for the error handler and pattern matching

Copy link
Collaborator

@connectdotz connectdotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what you test is perfectly all right for unit testing. Thanks for taking the time to improve the plugin and its test coverage!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants