auto recovery with login-shell when encountered command not found issue #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3442324402
💛 - Coveralls |
connectdotz
changed the title
legend1202
pushed a commit
to legend1202/vscode-jest
that referenced
this pull request
Jun 18, 2023
…ue (jest-community#941) * added fallback to login-shell logic * update doc * adding test and correct a regex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many complaints about intermittent test run failure (exit code 127) with
"command not found"or"No such file or directory"errors for programs like node/npm/yarn. While it is not caused by this extension, it significantly impacted our users' experience nevertheless.With the recent implementation of the login-shell, I think we can finally address this once and for all. This PR implemented an auto-retry with a login shell when detected the situation mentioned above.
This is only applicable for non-windows platforms. The currently supported login shell are:
bash,zsh,fish.fixes #899
fixes #845
fixes #874
fixes #867