Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

execute dynamic-named tests with parent names #959

Merged

Conversation

connectdotz
Copy link
Collaborator

When running tests via the editor gutter menu, test names, such as parameterized tests or template-literal-named test, might not have been resolved. Executing these tests often leads to "no test found" error and will require users to run the parent block with resolved names. This PR will automatically perform this fallback logic when detecting the test has an unresolved name.

Also, refactor and simplify the following:

  1. refactor JestRun to remove unnecessary "request" attr.
  2. removed "test-parsed" from TestSuitChangeEvent
  3. reduces unnecessary test item rendering during TestSuitChangeEvent processing

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3605633019

  • 14 of 15 (93.33%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 97.342%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/test-provider/test-item-data.ts 8 9 88.89%
Totals Coverage Status
Change from base Build 3570868980: 0.02%
Covered Lines: 3271
Relevant Lines: 3307

💛 - Coveralls

@connectdotz connectdotz merged commit 0a53f42 into jest-community:master Dec 2, 2022
@connectdotz connectdotz deleted the execute-dynamic-tests branch December 2, 2022 22:53
legend1202 pushed a commit to legend1202/vscode-jest that referenced this pull request Jun 18, 2023
* invoke parent's scheduleTest for unresolved test names

* remove request from JestTestRun

* clean up

* adding tests

* remove test-parsed event
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants