fix: remove getVmContext from node env on older versions of node

jestjs · Mar 26, 2020 · 47e5ecc · 47e5ecc
1 parent a679390
commit 47e5ecc
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,8 @@
 
 ### Fixes
 
+- `[jest-environment-node]` Remove `getVmContext` from Node env on older versions of Node ([#9706](https://github.com/facebook/jest/pull/9706))
+
 ### Chore & Maintenance
 
 ### Performance

diff --git a/packages/jest-environment-node/package.json b/packages/jest-environment-node/package.json
@@ -21,7 +21,11 @@
     "@jest/fake-timers": "^25.2.1",
     "@jest/types": "^25.2.1",
     "jest-mock": "^25.2.1",
-    "jest-util": "^25.2.1"
+    "jest-util": "^25.2.1",
+    "semver": "^6.3.0"
+  },
+  "devDependencies": {
+    "@types/semver": "^6.2.0"
   },
   "engines": {
     "node": ">= 8.3"

diff --git a/packages/jest-environment-node/src/index.ts b/packages/jest-environment-node/src/index.ts
@@ -14,6 +14,7 @@ import {
   LolexFakeTimers,
 } from '@jest/fake-timers';
 import type {JestEnvironment} from '@jest/environment';
+import {lt as semverLt} from 'semver';
 
 type Timer = {
   id: number;
@@ -121,4 +122,11 @@ class NodeEnvironment implements JestEnvironment {
   }
 }
 
+// node 10 had a bug in `vm.compileFunction` that was fixed in https://github.com/nodejs/node/pull/23206.
+// Let's just pretend the env doesn't support the function.
+// Make sure engine requirement is high enough when we drop node 8 so we can remove this condition
+if (semverLt(process.version, '10.14.2')) {
+  delete NodeEnvironment.prototype.getVmContext;
+}
+
 export = NodeEnvironment;
diff --git a/yarn.lock b/yarn.lock
@@ -2489,7 +2489,7 @@
   dependencies:
     "@types/node" "*"
 
-"@types/semver@^6.0.1", "@types/semver@^6.2.1":
+"@types/semver@^6.0.1", "@types/semver@^6.2.0", "@types/semver@^6.2.1":
   version "6.2.1"
   resolved "https://registry.yarnpkg.com/@types/semver/-/semver-6.2.1.tgz#a236185670a7860f1597cf73bea2e16d001461ba"
   integrity sha512-+beqKQOh9PYxuHvijhVl+tIHvT6tuwOrE9m14zd+MT2A38KoKZhh7pYJ0SNleLtwDsiIxHDsIk9bv01oOxvSvA==