Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors running yarn test in this repository #4449

Closed
doowb opened this issue Sep 7, 2017 · 5 comments · Fixed by #4450
Closed

Errors running yarn test in this repository #4449

doowb opened this issue Sep 7, 2017 · 5 comments · Fixed by #4450

Comments

@doowb
Copy link
Contributor

doowb commented Sep 7, 2017

Do you want to request a feature or report a bug?

bug?

What is the current behavior?

I'm trying to setup the jest repository to run tests before making a change to submit a pull request. I got to a point where when running yarn test results in flow: unknown option '--silent'.

What is the expected behavior?

Be able to run tests.

Please provide your exact Jest configuration and mention your Jest, node, yarn/npm version and operating system.

system version
jest master branch
node v8.4.0
yarn 1.0.1
lerna 2.1.2
npm 5.3.0
os macOS Sierra v10.12.1

I had previously followed the contributing guide and installed the necessary software to run the tests and was able to submit a PR, but since getting the latest from the repository and updating, it seems like I'm having more problems.

Before upgrading any external software, I ran the following commands:

git pull origin master
yarn install
yarn test

the typecheck step in yarn test ran then and go received a lot of flow errors saying that modules didn't exist. So I figured that I had to do something with lerna to install dependencies for the packages. I installed lerna and ran lerna bootstrap, but there weren't any new node_modules folders in the packages.

After finding some issues about yarn and lerna workspaces, I thought that might mean that I need to upgrade yarn (I had v0.25.x) and it would handle the packages' dependencies. That's when I ran:

brew update
brew upgrade

I then ran yarn run clean-all to ensure all of the node_modules are cleared out and ran yarn again to install the dependencies. This results in the dependencies being installed but the build step failing. I'm able to run yarn run build directly, then tried to run yarn test and received the error mentioned above.

I thought I'd ask here since I don't know if there is something else that I missed or if I have something on my machine that's conflicting.

@cpojer
Copy link
Member

cpojer commented Sep 7, 2017

Somebody needs to send a PR to remove the -- and remove the --silent from the scripts commands in package.json. This change was made today in Yarn.

@cpojer
Copy link
Member

cpojer commented Sep 7, 2017

Would you mind sending that PR? :)

@doowb
Copy link
Contributor Author

doowb commented Sep 7, 2017

I'd be happy too. There is also a --silent on lerna publish. Should that be removed also?

I did this locally and the tests are running now, thanks!

doowb added a commit to doowb/jest that referenced this issue Sep 7, 2017
 - removes the silent flag from package.json scripts
 - closes jestjs#4449
@cpojer
Copy link
Member

cpojer commented Sep 7, 2017

go for it.

@doowb doowb mentioned this issue Sep 7, 2017
cpojer pushed a commit that referenced this issue Sep 7, 2017
- removes the silent flag from package.json scripts
 - closes #4449
tabrindle pushed a commit to tabrindle/jest that referenced this issue Oct 2, 2017
- removes the silent flag from package.json scripts
 - closes jestjs#4449
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants