Since Jest 23.2.0: "Coverage data for global was not found." #6563

Vinnl · 2018-06-27T08:52:29Z

🐛 Bug Report

This is going to be somewhat of a difficult bug report since there's many moving parts and I'm not sure which causes it, but since upgrading Jest from 23.1.0 to 23.2.0, I'm currently running into the following error on one of my projects:

=============================== Coverage summary ===============================
Statements   : Unknown% ( 0/0 )
Branches     : Unknown% ( 0/0 )
Functions    : Unknown% ( 0/0 )
Lines        : Unknown% ( 0/0 )
================================================================================
Jest: Coverage data for global was not found.

Apart from the upgrade (which did encompass quite a few packages to be upgraded along with jest proper), nothing changed in my setup.

I'm using TypeScript with ts-jest, if relevant.

To Reproduce

$ git clone -b deps/update-46517a0f [email protected]:Flockademic/Flockademic.git
$ yarn
$ yarn run jest

Unfortunately I wouldn't know how to reproduce this in a fresh repo...

Expected behavior

Tests to succeed (which is happening now) and coverage to be 100% everywhere.

Link to repl or repo (highly encouraged)

Not minimal unfortunately, but as I referenced above: git clone -b deps/update-46517a0f [email protected]:Flockademic/Flockademic.git.

Run `npx envinfo --preset jest`

Paste the results here:

  System:
    OS: Linux 4.13 Ubuntu 16.04.4 LTS (Xenial Xerus)
    CPU: x64 Intel(R) Core(TM) i7-7500U CPU @ 2.70GHz
  Binaries:
    Node: 8.10.0 - ~/.nvm/versions/node/v8.10.0/bin/node
    Yarn: 1.7.0 - /usr/bin/yarn
    npm: 5.6.0 - ~/.nvm/versions/node/v8.10.0/bin/npm
  npmPackages:
    @types/jest: 23.1.1 => 23.1.1
    jest: 23.2.0 => 23.2.0

The text was updated successfully, but these errors were encountered:

palmerj3 · 2018-06-27T14:18:40Z

@Vinnl I suspect that this is due to ts-jest not being compatible with jest 23. There is an issue on the ts-jest repo to investigate compatibility. kulshekhar/ts-jest#589

TheCodeDestroyer · 2018-07-04T17:12:25Z

@palmerj3 I don't use types and I get the same error

Sent from my Nexus 5X using FastHub

Rukeith · 2018-07-05T13:20:10Z

I got the same issue and I just use pure javascript.

AodhanHayter · 2018-07-05T21:28:44Z

I'm having the same issue, dropping down to [email protected] resolves the issue. Any version at 23.x.x gives me the same problem. Maybe config options have changed?

Rukeith · 2018-07-06T00:42:46Z

I notice 23.x.x add a options --coverage, but it still not work while I add to command line.

jongear · 2018-07-06T20:05:41Z

With pure javascript, I also received the Jest: Coverage data for global was not found. error in [email protected]

package.json for reference

 {
  "name": "my-package",
  "version": "0.0.0",
  "private": true,
  "scripts": {
    "test": "jest",
    "test:coverage": "jest --coverage",
    "report-coverage": "npm run test:coverage && cat ./coverage/lcov.info | codecov",
  },
  "jest": {
    "coverageThreshold": {
      "global": {
        "branches": 50,
        "functions": 50,
        "lines": 50,
        "statements": 50
      }
    },
    "collectCoverageFrom": [
      "src/**/*.{js}",
      "!**src/config/*.{js}",
      "!**src/config/*/*.{js}",
      "!**src/docs/*.{js}",
      "!**src/models/*.{js}"
    ]
  },
  "devDependencies": {
    "codecov": "^3.0.3",
    "eslint": "^4.19.1",
    "eslint-config-prettier": "^2.9.0",
    "eslint-plugin-prettier": "^2.6.2",
    "jest": "^23.3.0",
    "prettier": "^1.13.7"
  }
}

For now, we have rolled back to [email protected] which works as expected

Tvrqvoise · 2018-07-06T23:44:21Z

I've found the issue. As part of #6400, micromatch was upgraded from version ^2.3.11 to ^3.1.10. Between these major versions, micromatch appears to have more closely adhered to Unix glob, which means breaking changes. Jest uses this library for matching the configuration values in package.json such as collectCoverageFrom, and hence some configurations which worked previously will no longer work.

For example, @jongear, in micromatch@2 you could do something like src/**/*.{js}. However, in micromatch@3 single-item sets are invalid and must now be either src/**/*.js or src/**/*.{js,}. Likewise, the same problem exists in @Vinnl's library -- lib/lambda/faas.ts is matched by lib/**.{js,ts} in micromatch@2, but must be lib/**/*.{js,ts} in micromatch@3.

I'll open a PR to revert micromatch back down to version 2. Not sure if FB wants to go down this route or not, but at least it's something -- someone on the Jest team should probably advise.

In the meantime, individuals can fix their issue by assuring that your glob patterns work in version 3.

Vinnl · 2018-07-09T08:10:47Z

That's fantastic @Tvrqvoise, I don't know how you managed to track that down, but I can confirm that updating the glob patterns fixed it for me.

Although micromatch@3 is a year old now apparently, its CHANGELOG does mention that there should be no breaking changes. I guess this change does look reasonable, but if it would be reason for Jest to downgrade to v2, then maybe we should report it as an issue there as well?

thymikee · 2018-07-09T08:15:32Z

I think we should file a PR to the changelog within micromatch then. @Vinnl would be so kind?

SimenB · 2018-07-09T11:22:45Z

I'm open to a revert, then upgrade it for Jest 24 along with the awesome explanation @Tvrqvoise provided about the gotchas. It's obviously super breaking, and landed in a minor (#6400).

Due to breaking changes in an upgrade of the dependency micromatch from ^2.3.11 to ^3.1.10 many users saw their coverage reporting failing because their glob matching was in an unsupported format. Adding the help text here gives users a good starting point for debugging when they run into issues concerning this option. This should help alleviate support issues created concerning this configuration option. Issue jestjs#6563 is a good example of what could be avoided in the future with this addition to the documentation.

## Summary As part of #6400, `micromatch` was updated. While `micromatch`'s CHANGELOG claims that this is safe, several regressions have been noted in cases where users relied upon invalid glob patterns. For example, these patterns would all match `src/foo/bar/baz.js`, but no longer do: - `src/**/*.{js}` - `src/**.js` - `src/**/*.{js|ts}` Fixes #6563 Fixes #6546 ## Test plan Unit tests were added which demonstrate the known cases.

Due to breaking changes in an upgrade of the dependency micromatch from ^2.3.11 to ^3.1.10 many users saw their coverage reporting failing because their glob matching was in an unsupported format. Adding the help text here gives users a good starting point for debugging when they run into issues concerning this option. This should help alleviate support issues created concerning this configuration option. Issue jestjs#6563 is a good example of what could be avoided in the future with this addition to the documentation.

…om (jestjs#6563) Due to breaking changes in an upgrade of the dependency micromatch from ^2.3.11 to ^3.1.10 many users saw their coverage reporting failing because their glob matching was in an unsupported format. Adding the help text here gives users a good starting point for debugging when they run into issues concerning this option. This should help alleviate support issues created concerning this configuration option.

Due to breaking changes in an upgrade of the dependency micromatch from ^2.3.11 to ^3.1.10 many users saw their coverage reporting failing because their glob matching was in an unsupported format. Adding the help text here gives users a good starting point for debugging when they run into issues rlated to this option. This will help alleviate support issues (such as jestjs#6563) concerning this configuration option.

fix an issue related to jestjs/jest#6563

Vinnl · 2018-07-11T13:04:03Z

Took me a while, but I reported an issue: micromatch/micromatch#133

(I did not submit a PR to the CHANGELOG yet, since I cannot exhaustively list the ways the globbing patterns have been restricted.)

github-actions · 2021-05-12T15:05:58Z

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

Rukeith mentioned this issue Jul 5, 2018

Coverage report 0% for everything #6208

Closed

thymikee mentioned this issue Jul 7, 2018

Coverage fails with collectCoverageFrom using alternate curly braces syntax #6654

Closed

Vinnl mentioned this issue Jul 9, 2018

Jest cant find any test with 23.2.0 #6546

Closed

Tvrqvoise added a commit to Tvrqvoise/jest that referenced this issue Jul 9, 2018

Roll back micromatch, fixes jestjs#6563

146f0af

Tvrqvoise added a commit to Tvrqvoise/jest that referenced this issue Jul 9, 2018

Roll back micromatch, fixes jestjs#6563

2edc2f3

Tvrqvoise mentioned this issue Jul 9, 2018

Roll back micromatch #6661

Merged

thymikee closed this as completed in #6661 Jul 9, 2018

AodhanHayter mentioned this issue Jul 9, 2018

Add help for configuration of collectCoverageFrom #6663

Merged

narr added a commit to narr/narr-material-ui that referenced this issue Jul 10, 2018

fix(root pkg-common): coverage data for global was not found

2d91653

fix an issue related to jestjs/jest#6563

Vinnl mentioned this issue Jul 11, 2018

solved: Regression from v3: matches that used to work no longer do micromatch/micromatch#133

Closed

AWolf81 mentioned this issue Sep 6, 2018

CI for coverage report setup joshwcomeau/guppy#219

Merged

github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Since Jest 23.2.0: "Coverage data for global was not found." #6563

Since Jest 23.2.0: "Coverage data for global was not found." #6563

Vinnl commented Jun 27, 2018

palmerj3 commented Jun 27, 2018

TheCodeDestroyer commented Jul 4, 2018 •

edited

Loading

Rukeith commented Jul 5, 2018

AodhanHayter commented Jul 5, 2018

Rukeith commented Jul 6, 2018

jongear commented Jul 6, 2018 •

edited

Loading

Tvrqvoise commented Jul 6, 2018 •

edited

Loading

Vinnl commented Jul 9, 2018

thymikee commented Jul 9, 2018

SimenB commented Jul 9, 2018

Vinnl commented Jul 11, 2018

github-actions bot commented May 12, 2021

Since Jest 23.2.0: "Coverage data for global was not found." #6563

Since Jest 23.2.0: "Coverage data for global was not found." #6563

Comments

Vinnl commented Jun 27, 2018

🐛 Bug Report

To Reproduce

Expected behavior

Link to repl or repo (highly encouraged)

Run npx envinfo --preset jest

palmerj3 commented Jun 27, 2018

TheCodeDestroyer commented Jul 4, 2018 • edited Loading

Rukeith commented Jul 5, 2018

AodhanHayter commented Jul 5, 2018

Rukeith commented Jul 6, 2018

jongear commented Jul 6, 2018 • edited Loading

Tvrqvoise commented Jul 6, 2018 • edited Loading

Vinnl commented Jul 9, 2018

thymikee commented Jul 9, 2018

SimenB commented Jul 9, 2018

Vinnl commented Jul 11, 2018

github-actions bot commented May 12, 2021

Run `npx envinfo --preset jest`

TheCodeDestroyer commented Jul 4, 2018 •

edited

Loading

jongear commented Jul 6, 2018 •

edited

Loading

Tvrqvoise commented Jul 6, 2018 •

edited

Loading