Jest ignores obsolete file snapshots if there are inline snapshots

[vlad-zhukov]

🐛 Bug Report

Jest ignores obsolete file snapshots if there are inline snapshots in this test.

To Reproduce

Steps to reproduce the behavior:

test('test', () => {
	expect('foo').toMatchSnapshot();
});

$ jest
 PASS  __tests__/test.js
  ✓ test (3ms)

 › 1 snapshot written.
Snapshot Summary
 › 1 snapshot written from 1 test suite.

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   1 written, 1 total
Time:        2.244s
Ran all test suites.

Change the above test to use inline snapshots:

test('test', () => {
	expect('foo').toMatchInlineSnapshot();
});

$ jest
 PASS  __tests__/test.js
  ✓ test (3ms)

 › 1 snapshot written.
Snapshot Summary
 › 1 snapshot written from 1 test suite.

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   1 written, 1 total
Time:        2.302s
Ran all test suites.

Now both a file and an inline snapshots exists. The file snapshot is completely ignored, Jest doesn't report that it's obsolete and doesn't remove it with jest -u.

Expected behavior

Jest should fail on obsolete snapshots and remove them with jest -u.

[rogeliog]

Thanks for reporting! This is a great point, I'm also able to reproduce.

I agree that it should mark the snapshot file as obsolete if it is not used anymore.

[SimenB]

/cc @azz

[azz]

Huh, I thought I tested that scenario, will be good to add an integration test for it once fixed.

[tiendq]

I've never used toMatchInlineSnapshot, when I tried it yesterday tests even failed until I added prettier and update jest. Was toMatchInlineSnapshot just added recently? if someone tell me its commit link?

Thanks,

[azz]

#6380 & https://github.com/facebook/jest/releases/tag/v23.3.0

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.