notifyMode is ignored when used at jest.config.js

[felipepastorelima]

🐛 Bug Report

The notifyMode is ignored when specified at jest.config.js, but not when used via CLI.
Tested on MacOS Mojave 10.14.5.

To Reproduce

Steps to reproduce the behavior:

// jest.config.js
module.exports = {
  notify: true,
  notifyMode: "failure"
};

// index.test.js
test("ok", () => {
  expect(true).toBe(true);
});

Run jest.

If you run it with jest --notifyMode=failure it will work. (It doesn't show the notify window)

Expected behavior

Not to show the notify window when notifyMode is failure and all tests pass.

Link to repl or repo (highly encouraged)

Not able to reproduce on repl.it demo.

[SimenB]

Huh, seems like a silly bug. Wanna send a PR fixing it? Without digging into it, I'd guess the error is in the normalize function in jest-config

[felipepastorelima]

Sure. Thanks for pointing the normalize function. I've made a shallow search and wasn't able to spot the problem. I'll dig into it tomorrow with time.

[felipepastorelima]

@SimenB The problem is that the defaults are set to the Argv, but the Argv has higher priority than the jest.config.js options.

It seems to be impacting other variables like 'maxConcurency', for example.

[SimenB]

CLI arguments should win over file config, but not defaults in argv... Not sure how to properly fix this. Ditch defaults from argv, perhaps?

/cc @thymikee @jeysal

[jeysal]

Yeah I'd say just do not specify yargs defaults, but jest-config Defaults.ts, I think that's what already happens for most things that can be arg and config.

[eungook]

notifyMode is still ignored. please help! 🙂

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.