chore: upgrade to typescript 3.9 #10031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
commented
May 13, 2020
| @@ -26,6 +26,7 @@ module.exports = { | |||
| 'error', | |||
| {argsIgnorePattern: '^_'}, | |||
| ], | |||
| '@typescript-eslint/prefer-ts-expect-error': 'error', | |||
| // Since we do `export =`. Remove for Jest 25 | |||
thymikee
reviewed
May 13, 2020
| this._environment.global[testTimeoutSymbol] = timeout; | ||
| } | ||
| return jestObject; | ||
| }; | ||
|
|
||
| const retryTimes = (numTestRetries: number) => { | ||
| // @ts-ignore: https://github.com/Microsoft/TypeScript/issues/24587 | ||
| // @ts-expect-error: https://github.com/Microsoft/TypeScript/issues/24587 |
There was a problem hiding this comment.
This issue is closed now, maybe we don't need to ignore?
There was a problem hiding this comment.
but if there’s no error, TypeScript will report that // @ts-expect-error wasn’t necessary
nevermind :D
There was a problem hiding this comment.
need to link to another issue probably then, as @ts-expect-error will error if it doesn't suppress an error
Codecov Report
@@ Coverage Diff @@
## master #10031 +/- ##
=======================================
Coverage 64.00% 64.00%
=======================================
Files 297 297
Lines 12528 12528
Branches 3093 3093
=======================================
Hits 8018 8018
Misses 3860 3860
Partials 650 650
Continue to review full report at Codecov.
|
jeysal
added a commit
to jeysal/jest
that referenced
this pull request
May 25, 2020
…esolve-outside * upstream/master: (106 commits) docs: fix jest-diff example (jestjs#10067) Cleanup `displayName` type (jestjs#10049) docs: correct confusing filename in `enableAutomock` example (jestjs#10055) chore: minor optimize getTransformer (jestjs#10050) chore: fix TestUtils.ts to match the types (jestjs#10034) Minor test name typo fix (jestjs#10033) chore: upgrade to typescript 3.9 (jestjs#10031) feat: CLI argument to filter tests by projects (jestjs#8612) chore: bump `istanbul-lib-instrument` (jestjs#10009) feat: support config files exporting (`async`) `function`s (jestjs#10001) fix: add missing haste-map dep to jest-snapshot (jestjs#10008) 🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉 (jestjs#10000) Fix typo in dependency warning (jestjs#10006) chore: add missing comma (jestjs#9999) fix: Control no diff message color with diff options (jestjs#9997) fix(jest-jasmine2): fix Error message (jestjs#9990) docs: fix jest-object ids for docusaurs (jestjs#9994) docs: fix Configuration, JestPlatform and JestObjectAPI docs for 26 (jestjs#9985) Add migration notes for breaking changes (jestjs#9978) chore: fix date and heading in blog post (jestjs#9977) ...
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://devblogs.microsoft.com/typescript/announcing-typescript-3-9/
Digging
@ts-expect-error!Test plan
Green CI