Check threshold only for changed files #10082
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently if we use
findRelatedTests
jest will check thresholds for every group fromcoverageThreshold
. So it always fails and it's impossible to run tests only for changed files on CI for example.This fix filters
thresholdGroups
by files fromcoveredFilesSortedIntoThresholdGroup
iffindRelatedTests
set and checks only filtered groups.If it looks good, I will add tests and changelog entry.
Also we can add same logic for all changes-related options:
--onlyChanged
,--changedFilesWithAncestor
,--changedSince
.Test plan
Add
coverageThreshold
in jest configand then run some tests with coverage not related to one in threshold configuration. For example:
yarn jest --findRelatedTests packages/jest-snapshot/src/dedentLines.ts --coverage --collectCoverageFrom packages/jest-snapshot/src/dedentLines.ts
(collectCoverageFrom is required beacuse of #10083 issue). It should pass