chore: replace make-dir with fs.mkdir
#10136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builtin fs.mkdir supports recursive option since node v10. See here https://nodejs.org/docs/latest-v10.x/api/fs.html#fs_fs_mkdirsync_path_options
SimenB
reviewed
Jun 23, 2020
| @@ -5,12 +5,12 @@ | |||
| * LICENSE file in the root directory of this source tree. | |||
| */ | |||
|
|
|||
| import makeDir = require('make-dir'); | |||
| import * as fs from 'graceful-fs'; | |||
| import type {Config} from '@jest/types'; | |||
|
|
|||
| export default function createDirectory(path: Config.Path): void { | |||
There was a problem hiding this comment.
should probably remove this helper at some point
SimenB
changed the title
make-dir with fs.mkdir
sauravhiremath
pushed a commit
to MLH-Fellowship/jest
that referenced
this pull request
Jul 20, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Builtin fs.mkdir supports recursive option since node v10.
See here https://nodejs.org/docs/latest-v10.x/api/fs.html#fs_fs_mkdirsync_path_option