Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Flow from vscode recommended extensions #10151

Merged
merged 1 commit into from
Jun 9, 2020
Merged

Remove Flow from vscode recommended extensions #10151

merged 1 commit into from
Jun 9, 2020

Conversation

lencioni
Copy link
Contributor

@lencioni lencioni commented Jun 9, 2020

Jest has migrated to TypeScript, so this extension is probably
not very useful in this repo anymore.

#7807

Summary

Test plan

Jest has migrated to TypeScript, so this extension is probably
not very useful in this repo anymore.

#7807
Copy link
Contributor

@jeysal jeysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, there's only very few files with @flow left I think

@jeysal jeysal requested a review from SimenB June 9, 2020 13:27
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't use vs code, but on face value this seems correct

@SimenB SimenB merged commit a35b9cc into jestjs:master Jun 9, 2020
@lencioni lencioni deleted the patch-1 branch June 9, 2020 16:41
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants