Fix the stale information about node-gyp & python #10181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Python 2.7 is deprecated https://www.python.org/doc/sunset-python-2/ * Python 2.7, 3.5...3.8 are supported https://github.com/nodejs/node-gyp#installation nodejs/node-gyp#1687 (comment)
SimenB
reviewed
Jun 23, 2020
CONTRIBUTING.md
Outdated
| @@ -34,7 +34,7 @@ _Before_ submitting a pull request, please make sure the following is done… | |||
|
|
|||
| 1. Jest uses [Yarn](https://code.facebook.com/posts/1840075619545360) for running development scripts. If you haven't already done so, please [install yarn](https://yarnpkg.com/en/docs/install). | |||
|
|
|||
| 1. Make sure you have `python` installed (v2.7 is recommended, v3.x.x is not supported). Python is required by [node-gyp](https://github.com/nodejs/node-gyp) that is used when running `yarn install`. | |||
| 1. Make sure you have `python` installed (v3.x is recommended, v2.7 [is not](https://www.python.org/doc/sunset-python-2/)). Python is required by [node-gyp](https://github.com/nodejs/node-gyp) that is used when running `yarn install`. | |||
There was a problem hiding this comment.
2.7 is still supported by node-gyp, maybe we could just say
Make sure you have
pythoninstalled. Python is required by node-gyp that is used when runningyarn install.
?
|
Thanks! |
sauravhiremath
pushed a commit
to MLH-Fellowship/jest
that referenced
this pull request
Jul 20, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.python.org/doc/sunset-python-2/
https://github.com/nodejs/node-gyp#installation
Why no support Python3 nodejs/node-gyp#1687 (comment)