Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jest-resolve] Add support for packageFilter for custom resolvers #10393

Merged
merged 9 commits into from
Aug 12, 2020
Merged

[jest-resolve] Add support for packageFilter for custom resolvers #10393

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3113ded
[iest-resolve] Add support for `packageFilter` for custom resolvers
scinos Aug 11, 2020
6bae80c
Fix lint problem in Configuration.md
scinos Aug 11, 2020
4f0ecc7
Adds entry in changelog
scinos Aug 11, 2020
fa5b272
Merge branch 'add/support-for-packageFilter' of github.com:scinos/jes…
scinos Aug 11, 2020
66335e0
Add example on how to use `packageFilter`
scinos Aug 11, 2020
141887e
Pull packageFilter type from "resolve"
scinos Aug 11, 2020
8325c0e
Add tests for packageFilter support
scinos Aug 11, 2020
e981f8f
Simplify example
scinos Aug 11, 2020
b1dd18a
Import from `resolve` just once
scinos Aug 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

### Features

- `[jest-resolve]` Add support for `packageFilter` on custom resolver ([#10393](https://github.com/facebook/jest/pull/10393))

### Fixes

### Chore & Maintenance
Expand Down
1 change: 1 addition & 0 deletions docs/Configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,6 +693,7 @@ This option allows the use of a custom resolver. This resolver must be a node mo
"extensions": [string],
"moduleDirectory": [string],
"paths": [string],
"packageFilter": "function(pkg, pkgdir)",
"rootDir": [string]
}
```
Expand Down
2 changes: 2 additions & 0 deletions packages/jest-resolve/src/defaultResolver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ type ResolverOptions = {
moduleDirectory?: Array<string>;
paths?: Array<Config.Path>;
rootDir?: Config.Path;
packageFilter?: (pkg: any, pkgfile: string) => any;
scinos marked this conversation as resolved.
Show resolved Hide resolved
};

declare global {
Expand All @@ -45,6 +46,7 @@ export default function defaultResolver(
isDirectory,
isFile,
moduleDirectory: options.moduleDirectory,
packageFilter: options.packageFilter,
paths: options.paths,
preserveSymlinks: false,
realpathSync,
Expand Down