feat: Add Console to custom console object #10502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark1626
force-pushed
the
node-global-console
branch
from
232d7bf
to
a83a831
Compare
|
The CI seems to be failing as the first line in the constructor of |
|
Regarding CI - no idea... I might be able to take a look this weekend, but no promises |
SimenB
force-pushed
the
node-global-console
branch
from
c6eb456
to
50c7ba4
Compare
SimenB
approved these changes
Sep 14, 2020
This was referenced Nov 17, 2020
This was referenced Mar 29, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add Console to
CustomConsoleandBufferedConsoleFixes #10282
Test plan
Tests have been added
cc: @jeysal