Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jest-runner): set exit code to 1 if test logs after teardown #10728

Merged
merged 3 commits into from
Nov 4, 2020
Merged

feat(jest-runner): set exit code to 1 if test logs after teardown #10728

merged 3 commits into from
Nov 4, 2020

Conversation

snitin315
Copy link
Contributor

Summary

Resolve #10715

Test plan

Green CI

@snitin315
Copy link
Contributor Author

I'm not sure under which section should I put it in Changelog. fix, feat, or something else?

@SimenB
Copy link
Member

SimenB commented Oct 28, 2020

I'm not sure under which section should I put it in Changelog. fix, feat, or something else?

feat 🙂 Make sure to mark it as breaking as well

@SimenB SimenB added this to the Jest 27 milestone Oct 28, 2020
@snitin315 snitin315 changed the title set exit code to 1 if test logs after teardown feat(jest-runner): set exit code to 1 if test logs after teardown Oct 28, 2020
SimenB
SimenB approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@NickHeiner
Copy link

Thank you for doing this!

@SimenB SimenB merged commit ddccb79 into jestjs:master Nov 4, 2020
@snitin315 snitin315 deleted the fail-jest branch November 5, 2020 04:52
jeysal added a commit to mmkal/jest that referenced this pull request Nov 8, 2020
@jeysal
Merge branch 'master' into uglier-inline-snapshots
13c960e 
* master: (398 commits)
  chore(breaking): remove undocumented `enabledTestsMap` config (jestjs#10787)
  Change expect.not.objectContaining() to match documentation (jestjs#10708)
  chore: add name to root project (jestjs#10782)
  Added explanation on how to use custom @jest-environment to docs (jestjs#10783)
  fix: remove deprecated functions from the jest object (jestjs#9853)
  chore: convert jest-runtime to ESM (jestjs#10325)
  fix(resolve): use escalade to find package.json (jestjs#10781)
  feat(jest-runner): set exit code to 1 if test logs after teardown (jestjs#10728)
  chore: add `exports` field to all `package.json`s (jestjs#9921)
  fix: do not inject `global` variable into module wrapper (jestjs#10644)
  chore: migrate jest-resolve to ESM (jestjs#10688)
  chore(transform): refactor API to pass an options bag around rather than multiple boolean options (jestjs#10753)
  chore: default to node test env rather than browser (jestjs#9874)
  fix: drop support for node 13 (jestjs#10685)
  chore: show enhanced syntax error for all syntax errors (jestjs#10749)
  chore: update lockfile after publish
  v26.6.3
  chore: update changelog for release
  Don't throw an error if mock dependency can't be found (jestjs#10779)
  chore: bump babel core types (jestjs#10772)
  ...
@SimenB SimenB mentioned this pull request Nov 14, 2020
Closed
@NMinhNguyen
Copy link

Does this change only affect non-watch mode? Because I can see that in Jest 27 tests still pass, except if I run it in non-watch mode, then the process will exit with exit code 1, but otherwise in watch mode, there's just a warning, but tests still pass.

@SimenB
Copy link
Member

SimenB commented Feb 28, 2021

That sounds like a bug. Could you open up a new issue?

@NMinhNguyen NMinhNguyen mentioned this pull request Feb 28, 2021
Closed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
Jest 27
Development

Successfully merging this pull request may close these issues.

Make Jest fail when a test logs after completing
5 participants
@snitin315 @SimenB @NickHeiner @NMinhNguyen @facebook-github-bot