chore(jest-transform): refactor transformer API to reduce number of arguments #10834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
Nov 16, 2020
SimenB
changed the title
SimenB
commented
Nov 16, 2020
| @@ -1,80 +1,98 @@ | |||
| // Jest Snapshot v1, https://goo.gl/fbAQLP | |||
|
|
|||
| exports[`ScriptTransformer passes expected transform options to getCacheKey 1`] = ` | |||
| Object { | |||
There was a problem hiding this comment.
ignore whitespace: https://github.com/facebook/jest/pull/10834/files?w=1
thymikee
reviewed
Nov 16, 2020
thymikee
approved these changes
Nov 16, 2020
thymikee
reviewed
Nov 16, 2020
| "unmockedModulePathPatterns": undefined, | ||
| "watchPathIgnorePatterns": Array [], | ||
| }, | ||
| "configString": "{\\"automock\\":false,\\"cache\\":true,\\"cacheDirectory\\":\\"/cache/\\",\\"clearMocks\\":false,\\"coveragePathIgnorePatterns\\":[],\\"cwd\\":\\"/test_root_dir/\\",\\"detectLeaks\\":false,\\"detectOpenHandles\\":false,\\"errorOnDeprecated\\":false,\\"extraGlobals\\":[],\\"forceCoverageMatch\\":[],\\"globals\\":{},\\"haste\\":{},\\"injectGlobals\\":true,\\"moduleDirectories\\":[],\\"moduleFileExtensions\\":[\\"js\\"],\\"moduleLoader\\":\\"/test_module_loader_path\\",\\"moduleNameMapper\\":[],\\"modulePathIgnorePatterns\\":[],\\"modulePaths\\":[],\\"name\\":\\"test\\",\\"prettierPath\\":\\"prettier\\",\\"resetMocks\\":false,\\"resetModules\\":false,\\"restoreMocks\\":false,\\"rootDir\\":\\"/\\",\\"roots\\":[],\\"runner\\":\\"jest-runner\\",\\"setupFiles\\":[],\\"setupFilesAfterEnv\\":[],\\"skipFilter\\":false,\\"skipNodeResolution\\":false,\\"slowTestThreshold\\":5,\\"snapshotSerializers\\":[],\\"testEnvironment\\":\\"node\\",\\"testEnvironmentOptions\\":{},\\"testLocationInResults\\":false,\\"testMatch\\":[],\\"testPathIgnorePatterns\\":[],\\"testRegex\\":[\\"\\\\\\\\.test\\\\\\\\.js$\\"],\\"testRunner\\":\\"jest-jasmine2\\",\\"testURL\\":\\"http://localhost\\",\\"timers\\":\\"real\\",\\"transform\\":[[\\"\\\\\\\\.js$\\",\\"test_preprocessor\\",{}]],\\"transformIgnorePatterns\\":[\\"/node_modules/\\"],\\"watchPathIgnorePatterns\\":[]}", |
There was a problem hiding this comment.
Looking at this snapshot and thinking if we need to bust the transform cache when any of the configuration options change? Wouldn't it be sufficient to only reset cache when transform output affecting config is changed, like cache, transform, cacheDirectory, extraGlobals? Downside would be maintaining such a list
There was a problem hiding this comment.
Downside would be maintaining such a list
exactly this. Might be worth it, tho
thymikee
reviewed
Nov 16, 2020
SimenB
force-pushed
the
refactor-transform-arguments
branch
from
8349594
to
afca168
Compare
SimenB
commented
Nov 16, 2020
| @@ -144,6 +144,7 @@ | |||
| }, | |||
| "resolutions": { | |||
| "@types/jest/jest-diff": "^25.1.0", | |||
| "@types/jest/pretty-format": "^25.1.0" | |||
| "@types/jest/pretty-format": "^25.1.0", | |||
| "fbjs-scripts": "patch:fbjs-scripts@^1.1.0#./patches/fbjs-scripts.patch" | |||
ahnpnl
reviewed
Nov 16, 2020
which docs? |
thymikee
reviewed
Nov 16, 2020
Co-authored-by: Michał Pierzchała <[email protected]>
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sorta for #10823 (comment). While writing the docs the arguments jumped out to me, so decided to refactor the code.
Test plan
Existing tests should pass, tweaked others