fix(jest-runtime): prevent global module registry from leaking into isolateModules registry

[toomuchdesign]

Summary

require statement inside isolateModules callbacks are unpredictable since they do not always return a fresh copy of imported modules. Currently if global registry has the require module in cache, the cached instance is returned even within `isolateModules. Fixes: #7863

This PR ensures that require statement inside isolateModules always return a fresh copy of imported modules.

Current behaviour

const myModule = require('myModule');

jest.isolateModules(() => {
  const myIsolatedModule = require('myModule');
  // myIsolatedModule === myModule;
});

New behaviour

const myModule = require('myModule');

jest.isolateModules(() => {
  const myIsolatedModule = require('myModule');
  // myIsolatedModule !== myModule;
});

Test plan

Added relevant test in: packages/jest-runtime/src/__tests__/runtime_require_module_or_mock.test.js

[facebook-github-bot]

Hi @toomuchdesign!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[SimenB]

good stuff, thanks! could you update the changelog as well?

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[toomuchdesign]

Hi @SimenB, I thought I did but it was still on my machine uncommitted :) Just force-pushed.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.