-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: missing collectCoverage after init (#11348) #11353
Conversation
Hi @davc0n! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! if you update the snapshot in packages/jest-cli/src/init/__tests__/init.test.js
CI should be happy as well 🙂
didn't find those tests before, should be ok now. CLA signed as well, but it keeps failing... |
Codecov Report
@@ Coverage Diff @@
## master #11353 +/- ##
==========================================
- Coverage 64.16% 64.15% -0.02%
==========================================
Files 308 308
Lines 13515 13515
Branches 3294 3294
==========================================
- Hits 8672 8670 -2
- Misses 4129 4130 +1
- Partials 714 715 +1
Continue to review full report at Codecov.
|
I have no idea what to do about the CLA thing. @JoelMarcey do you have any idea? |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
I think we are good now here, right? |
Yep, thanks @JoelMarcey! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
#11348
Test plan
jest --init