Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add --filter to the CLI doc #11357

Merged
merged 2 commits into from
May 4, 2021
Merged

docs: Add --filter to the CLI doc #11357

merged 2 commits into from
May 4, 2021

Conversation

tiggreen
Copy link

Summary

I noticed that --filter is missing from the website docs but it exists in jest --help. This PR fixes it.

Test plan

`--filter` option is present in `jest --help` but is missing from CLI docs.
@facebook-github-bot
Copy link
Contributor

Hi @tiggreen!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@tiggreen tiggreen changed the title Add --filter to the CLI doc docs: Add --filter to the CLI doc Apr 29, 2021
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! could you also update the versioned docs?

image

Also need to fill out CLA 🙂

@tiggreen
Copy link
Author

tiggreen commented May 3, 2021

@SimenB done! I did sign the CLA but for some reason, it doesn't show up here?

@codecov-commenter
Copy link

Codecov Report

Merging #11357 (ba8dfeb) into master (4c3643c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11357   +/-   ##
=======================================
  Coverage   64.16%   64.16%           
=======================================
  Files         308      308           
  Lines       13515    13515           
  Branches     3294     3294           
=======================================
  Hits         8672     8672           
  Misses       4129     4129           
  Partials      714      714           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c3643c...ba8dfeb. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@SimenB SimenB merged commit ba84480 into jestjs:master May 4, 2021
@github-actions
Copy link

github-actions bot commented Jun 4, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants