Move jest-get-type to ESM named exports #11359
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I tried using jest's
expect
together with snowpack (which converts everything to esm via rollup/plugin-commonjs), and it mostly worked okay except I was gettingTypeError: (0 , _jestGetType.default) is not a function
I traced this down to a problem in how rollup/babel (or the combination of them) deal with mixed default and named exports. The rollup docs specifically talk about avoiding mixing the two, as well. I see that all of the other jest packages (except for pretty-format, which also causes me errors) are using either default or named exports, so I chose to use named exports and convert
jest-get-type
to esm.Test plan
I built the code, copied all of the newly built files to my node_modules, and my error went away. Also, existing tests continue to pass.