-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: reference prettier in inline snapshots section #11566
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not necessarily true in Jest 27 (due to #7792). But we can add this note to v25 and v26 of the docs 🙂 Could you update this PR to do that?
Ah thanks @SimenB I'd missed that one. Yes I'll target the change to those versions as you say. For 27.0 and next, would you still like to say something to the effect of "If we find prettier, we'll use it, otherwise don't worry"? |
Yep! |
@SimenB done! |
@davidjgoss sorry, completely lost track of this - can you merge |
@SimenB no worries, will do! |
@SimenB all done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
See #8467.
When using
toMatchInlineSnapshot()
, the implicit dependency onprettier
can be a source of confusion, so briefly adding a mention in the docs.Test plan
(Docs only.)