Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: reference prettier in inline snapshots section #11566

Merged
merged 12 commits into from
Feb 23, 2022
Merged

docs: reference prettier in inline snapshots section #11566

merged 12 commits into from
Feb 23, 2022

Conversation

davidjgoss
Copy link
Contributor

Summary

See #8467.

When using toMatchInlineSnapshot(), the implicit dependency on prettier can be a source of confusion, so briefly adding a mention in the docs.

Test plan

(Docs only.)

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not necessarily true in Jest 27 (due to #7792). But we can add this note to v25 and v26 of the docs 🙂 Could you update this PR to do that?

image

@davidjgoss
Copy link
Contributor Author

Ah thanks @SimenB I'd missed that one. Yes I'll target the change to those versions as you say. For 27.0 and next, would you still like to say something to the effect of "If we find prettier, we'll use it, otherwise don't worry"?

@SimenB
Copy link
Member

SimenB commented Jun 14, 2021

For 27.0 and next, would you still like to say something to the effect of "If we find prettier, we'll use it, otherwise don't worry"?

Yep!

@davidjgoss
Copy link
Contributor Author

@SimenB done!

@SimenB
Copy link
Member

SimenB commented Feb 23, 2022

@davidjgoss sorry, completely lost track of this - can you merge main again and then update the new versioned docs? Sorry! 🙈 I'll make sure to land it this time!

@davidjgoss
Copy link
Contributor Author

@SimenB no worries, will do!

@davidjgoss
Copy link
Contributor Author

@SimenB all done :)

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SimenB SimenB merged commit a1117f9 into jestjs:main Feb 23, 2022
@davidjgoss davidjgoss deleted the patch-1 branch February 23, 2022 10:27
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants