-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(jest-haste-map): Add computeDependencies to cache path #11916
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems reasonable 👍
83705af
to
ec6c7db
Compare
Codecov Report
@@ Coverage Diff @@
## main #11916 +/- ##
==========================================
+ Coverage 68.74% 68.76% +0.01%
==========================================
Files 322 322
Lines 16591 16591
Branches 4787 4787
==========================================
+ Hits 11406 11408 +2
+ Misses 5152 5151 -1
+ Partials 33 32 -1
Continue to review full report at Codecov.
|
@motiz88 is this something you need a release of now, or is it fine to wait until whenever I make another release? |
@SimenB No rush - this has no significant effect on Metro in open source, and internally we're currently using a fork that adds hooks for some other FB-internal systems. I'll keep sending PRs for stuff we can upstream. Thanks for the speedy review! |
Cool, thanks! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
#6667 added the
computeDependencies
option, which affects the contents of the Haste map, but doesn't change the cache path. If twojest-haste-map
instances are created with identical options except forcomputeDependencies
, the one withcomputeDependencies: true
could end up attempting to reuse cached data where the dependencies are missing.Here we add the value of
computeDependencies
to the cache path.Test plan
Added a unit test.