fix: construct matcher context for asymmetric matchers on demand #11930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
commented
Oct 5, 2021
| @@ -68,16 +68,16 @@ export const setMatchers = ( | |||
|
|
|||
| asymmetricMatch(other: unknown) { | |||
| const {pass} = matcher.call( | |||
| this.matcherState, | |||
| this.getMatcherContext(), | |||
Codecov Report
@@ Coverage Diff @@
## main #11930 +/- ##
==========================================
- Coverage 68.75% 68.74% -0.01%
==========================================
Files 322 322
Lines 16589 16587 -2
Branches 4786 4786
==========================================
- Hits 11405 11403 -2
Misses 5152 5152
Partials 32 32
Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
SimenB
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following up #11926. That constructs the context when the matcher is created rather than when it's called, which is wrong (i.e. number of assertions would be wrong).
Test plan
Green CI