chore(resolver): reuse cached lookup of package.json files #11969
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Supporting
exports
field will lead us to reading way morepackage.json
files than before, so in preparation we should try to make these caches cooperate and populate the same one.I've also dropped
escalade
as it does a bunch ofstatSync
calls - we do as well and cache them, so re-using makes sense.Lastly, I've moved the clearing of these caches until just before running tests (instead of only before runs in watch mode) in case some resolution is different between config loading and test running
Test plan
Green CI