-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(jest-config): add missing slash dependency #12080
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! please run yarn
and add an entry to the changelog 🙂
Haha, I give up. You may want to look at this yourself. Looks like the
I committed a workaround to treat I don't have bandwidth to investigate this further. 😢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the issues you were seeing was due to using slash@4 which is ESM native. Downgrading to v3 (which is what we use elsewhere) should fix it 🙂
Codecov Report
@@ Coverage Diff @@
## main #12080 +/- ##
=======================================
Coverage 68.88% 68.89%
=======================================
Files 324 324
Lines 16669 16669
Branches 4814 4814
=======================================
+ Hits 11483 11484 +1
+ Misses 5153 5152 -1
Partials 33 33
Continue to review full report at Codecov.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Adds dependency to
package.json
.resolveConfigPath
requiresslash
as a dependency, but this dependency is not declared inpackage.json
, making it ambiguous.