-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: correct watching dot files #12161
Conversation
Codecov Report
@@ Coverage Diff @@
## main #12161 +/- ##
=======================================
Coverage 67.72% 67.72%
=======================================
Files 328 328
Lines 16993 16993
Branches 4818 4818
=======================================
Hits 11508 11508
Misses 5452 5452
Partials 33 33 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm on it! Since the change in behaviour happened in version 26.2.0, the doc for 26.x should probably describe the behaviour before and after the change, right? Also, do I need to add an item in the changelog or is this too trivial? |
The way the
Not needed as it won't be part of any code that's released 👍 |
I think I should clarify that version control folders are ignored or it might cause unnecessary concern. What do you think of this alternative wording?
|
Yeah, that sounds good. Thanks! |
Prettier is unhappy, mind running it? |
Sorry about that. I didn't realise it was necessary for documentation. |
No worries! 😀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thanks!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
The current config documentation states that the watcher ignores dot files and folders by default. This behaviour was changed by PR #10075 back in 2020.
As a user of Nextjs, I noticed that running the dev server concurrently with
jest --watch
caused Jest to constantly rerun all the tests when no source file had changed. This was due to the dev server writing to folder/.next
, with the Jest watcher enthusiastically kicking in. The incorrect documentation made much harder to find the origin of the problem.Test plan
This is purely documentation, limited to the paragraph about dotfiles watching in section
watchPathIgnorePatterns
.