-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): add needed capitalization #12246
Conversation
Beginning of new sentence needs capitalization.
Codecov Report
@@ Coverage Diff @@
## main #12246 +/- ##
=======================================
Coverage 67.51% 67.51%
=======================================
Files 328 328
Lines 17246 17246
Branches 5071 5071
=======================================
Hits 11643 11643
Misses 5570 5570
Partials 33 33 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hello @Cambuchi thanks for the PR, but why did you made two similar PR, and yes you are right the starting letter should be uppercase, but webpack is written in this way, even in their official site, w
link- https://webpack.js.org/ is smallcase so think this change is not important.
thank you.
@Biki-das Webpack definitely capitalizes itself when it's the first word even on it's own documentation. See below from their own docs: I found the error on two different files and did quick edits through GitHub not in an editor. Hence the two PRs. |
@Cambuchi would you close the previous one, and just push it from the new one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing, versioned files have edits committed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Beginning of new sentence needs capitalization.