feat: export test environments as ESM #12340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
commented
Feb 9, 2022
| @@ -161,4 +161,4 @@ class JSDOMEnvironment implements JestEnvironment<number> { | |||
| } | |||
| } | |||
|
|
|||
| export = JSDOMEnvironment; | |||
| export const TestEnvironment = JSDOMEnvironment; | |||
There was a problem hiding this comment.
for ease of use for consumers who don't wanna use default
SimenB
changed the title
SimenB
force-pushed
the
test-env-export
branch
from
2898136
to
c629a3f
Compare
Codecov Report
@@ Coverage Diff @@
## main #12340 +/- ##
==========================================
- Coverage 66.97% 66.96% -0.01%
==========================================
Files 329 329
Lines 17338 17335 -3
Branches 5066 5061 -5
==========================================
- Hits 11612 11609 -3
Misses 5694 5694
Partials 32 32
Continue to review full report at Codecov.
|
noseworthy
added a commit
to noseworthy/jest-mongodb
that referenced
this pull request
Mar 7, 2022
Jest v28 is going to start using ESM, and the latest release candidate has started exporting modules with ESM syntax: jestjs/jest#12340 This breaks jest-mongodb when importing jest-environment-node. In order to properly import this module when running in jest v28 we need to look for the default export. If the default export is present, use that, otherwise use the test environment as normal.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
export =messes with some bundling I'm looking at, so let's get rid of it.(Jest itself already handles importing test envs written as ESM (fake or not))
Test plan
Green CI