Added a 30 Minute timeout for infinite loops #12570
Conversation
|
This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
| runScript = script.runInContext(vmContext, { | ||
| filename, | ||
| timeout: defaultTimeout * 60000, | ||
| }); |
There was a problem hiding this comment.
I have tested that code with Node.js (16.x) and an infinite loop in my test -- it does not work.
I'm also confused: According to
https://nodejs.org/api/vm.html#scriptrunincontextcontextifiedobject-options
the options parameter only support displayErrors, timeout and breakOnSigint -- but no filename.
|
This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
|
This PR was closed because it has been stalled for 30 days with no activity. Please open a new PR if the issue is still relevant, linking to this one. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Added a 30 Minute default timeout to stop tests in case of infinite loops. Uses Node.js
runInContext()timeout option as it is used in jest runtime. Resolves #9785