.toBeNull and .toBeDefined / .toBeUndefined #1270
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
maximderbin
force-pushed
the
null_defined_undefined_matchers
branch
from
a993c09
to
bcabbe2
Compare
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
ghost
added
the
maximderbin
force-pushed
the
null_defined_undefined_matchers
branch
from
bcabbe2
to
4418784
Compare
| expect(() => jestExpect(v).not.toBeDefined()) | ||
| .toThrowError(/not to be defined/); | ||
| expect(() => jestExpect(v).toBeUndefined()) | ||
| .toThrowError(/undefined/); |
There was a problem hiding this comment.
can you add a little more text to this regex?
there's a hight change of false green if you just match it to /undefined/ :)
There was a problem hiding this comment.
@DmitriiAbramov done
|
thanks @maximderbin! |
maximderbin
force-pushed
the
null_defined_undefined_matchers
branch
from
4418784
to
0d466e7
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
No description provided.