fix: symbol key could not be enum.

[eryue0220]

Summary

Fix: #14308

Test plan

Test at local.

e2e/__tests__/symbolKey.test.ts
  ✓ run test with symbol key (297 ms)

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   1 passed, 1 total
Time:        0.596 s, estimated 1 s

[netlify]

✅ Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	b5e0252
🔍 Latest deploy log	https://app.netlify.com/sites/jestjs/deploys/64dded67b2d01d00073a0706
😎 Deploy Preview	https://deploy-preview-14414--jestjs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[mrazauskas]

Thanks. I left a couple of comments.

Also rebase the branch, please. The lint error should go away.

[mrazauskas]

Thanks. Implementation looks good. Please consider #14414 (comment)

The thing is that writing e2e tests for all the use cases of asymmetric matchers would create too many files. In this case unit tests are sufficient. They allow creating lots of test cases easily. For example, did you consider adding a negative test?

Keep in mind that expect can be installed and used without Jest. Therefore keeping its tests inside the package boundaries is also good idea.

[eryue0220]

Thanks. Implementation looks good. Please consider #14414 (comment)

The thing is that writing e2e tests for all the use cases of asymmetric matchers would create too many files. In this case unit tests are sufficient. They allow creating lots of test cases easily. For example, did you consider adding a negative test?

Keep in mind that expect can be installed and used without Jest. Therefore keeping its tests inside the package boundaries is also good idea.

Ok, thank you. I will fix it later

[SimenB]

thanks!

[SimenB]

https://github.com/jestjs/jest/releases/tag/v29.6.3

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.