Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Jest on Windows #1463

Merged
merged 1 commit into from
Aug 27, 2016
Merged

Fixes for Jest on Windows #1463

merged 1 commit into from
Aug 27, 2016

Conversation

Daniel15
Copy link
Contributor

  • Upgrade Lerna. Lerna 2.0 beta 24 has known issues in Windows: It appears to run successfully but actually doesn't do anything (lerna bootstrap fails with "-4058" lerna/lerna#226 (comment)). Need to upgrade to beta 26 to get an actual working version.
  • The regex in package.json wasn't working correctly for some reason. Moving the \ to the right spot (before the .) fixed it. (6c76202)
  • SearchSource was incorrectly escaping \ characters in the file path. To avoid this, we convert the \ to / before running escapeStrForRegex. replacePathSepForRegex (which is what pathToRegex calls) converts it back to the correct separator anyways.

Fixes #1462

@codecov-io
Copy link

codecov-io commented Aug 19, 2016

Current coverage is 63.21% (diff: 16.66%)

Merging #1463 into master will decrease coverage by 0.08%

@@             master      #1463   diff @@
==========================================
  Files            96         96          
  Lines          3608       3613     +5   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           2284       2284          
- Misses         1324       1329     +5   
  Partials          0          0          

Powered by Codecov. Last update 081bdd5...346ec92

@Daniel15
Copy link
Contributor Author

Daniel15 commented Aug 19, 2016

cc @cpojer - The SearchSource change broke Windows support between 14.1.0 and master, and thus should be considered launch blocking for the next release.

@cpojer cpojer merged commit c447de1 into jestjs:master Aug 27, 2016
@cpojer
Copy link
Member

cpojer commented Aug 27, 2016

thank you <3

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"no tests found" when running master on Windows
3 participants