-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AppVeyor configuration #1465
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
environment: | ||
matrix: | ||
- nodejs_version: "4" | ||
- nodejs_version: "6" | ||
|
||
install: | ||
- ps: Install-Product node $env:nodejs_version x64 | ||
- npm i -g npm@latest | ||
- node --version | ||
- npm --version | ||
- npm install | ||
|
||
test_script: | ||
- npm run build | ||
# Hax - Some snapshot tests don't currently work on Windows, so the tests are | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe remove this There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I need the hack for now, otherwise the build fails :( I'll remove it at Sent from my phone. On Sep 2, 2016 12:50 PM, "Christoph Pojer" [email protected] wrote:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No no, sorry I mean the word "Hax". :D |
||
# commented out. Jest complains that obsolete snapshot files exist, so the | ||
# "-u" will just delete those snapshots when running in the AppVeyor run, | ||
# instead of failing the build. | ||
- npm run jest -- -u --color | ||
|
||
# Don't actually build. | ||
build: off |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's just not support node 4 on windows. I don't think we'll be able to do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any issues with Node 4 that would cause it to break?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No but I'm deciding right now that the only node version we support on Windows will be the latest.