Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test on Node.js 22 #15035

Merged
merged 2 commits into from
Apr 25, 2024
Merged

chore: test on Node.js 22 #15035

merged 2 commits into from
Apr 25, 2024

Conversation

mrazauskas
Copy link
Contributor

Summary

Node.js 22 is released: https://github.com/nodejs/node/releases/tag/v22.0.0

This PR add Node.js 22 to the test matrix and bumps nightly version to 23 (it will get incremented as well, or?).

Test plan

Green CI

Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1ae5ca4
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/6629ed6aaa3cd0000819daf8
😎 Deploy Preview https://deploy-preview-15035--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SimenB
Copy link
Member

SimenB commented Apr 24, 2024

seems we have a failing test? 🤔

@mrazauskas
Copy link
Contributor Author

This is import assertions test and the very first item in v22 release notes says:

I will take a better look a bit later. Can be that the test must be simply skipped for v22.

@SimenB
Copy link
Member

SimenB commented Apr 25, 2024

Oh, I missed the spec changing. Do we support with? Feels like we should just remove the entire import assertions support and implement the new thing.

Not for this PR, tho!

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit b019f50 into jestjs:main Apr 25, 2024
84 checks passed
@mrazauskas mrazauskas deleted the test-on-node-22 branch April 25, 2024 10:08
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants