fix: correctly copy getters in deepCyclicCopy
#15265
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jestjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SimenB
changed the title
deepCyclicCopydeepCyclicCopy
SimenB
force-pushed
the
handle-errors-in-cyclic-copy
branch
2 times, most recently
from
920f35d
to
a3694e0
Compare
SimenB
force-pushed
the
handle-errors-in-cyclic-copy
branch
from
a3694e0
to
2ecfd4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #15196
deepCyclicCopyReplaceablejust accesses the value unconditionally, but we have tests indeepCyclicCopythat getters are not accessed.jest/packages/jest-matcher-utils/src/deepCyclicCopyReplaceable.ts
Lines 104 to 109 in 91e8082
Not sure if this is the correct approach, but seems fine? Let's see what CI says
Test plan
Unit test added