new module defaults #1668
new module defaults #1668
Conversation
ghost
added
the
Current coverage is 89.93% (diff: 100%)@@ master #1668 diff @@
==========================================
Files 31 31
Lines 1143 1143
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1028 1028
Misses 115 115
Partials 0 0
|
|
TypeScript currently requires a custom preprocessor and we don't have an official one and there are issues with source map support. I'm worried people might have js build files and ts source files and that with this change both of them will be picked up. I'm not sure how much of a concern that is, just worried it might mess things up. What do you think? |
aaronabramov
force-pushed
the
module-defaults
branch
from
8aba7c5
to
fb9314a
Compare
|
removed typescript |
| @@ -33,7 +33,7 @@ module.exports = ({ | |||
| }, | |||
| mocksPattern: '__mocks__', | |||
| moduleDirectories: ['node_modules'], | |||
| moduleFileExtensions: ['js', 'json', 'node'], | |||
| moduleFileExtensions: ['js', 'json', 'node', 'jsx'], | |||
There was a problem hiding this comment.
can you sort these alphabetically?
aaronabramov
force-pushed
the
module-defaults
branch
from
fb9314a
to
941671b
Compare
|
even better defaults! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
No description provided.