Make jest-cli a real module. #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While tests are running, print out the number of remaining tests being waited on. This looks nice when running a large number of tests
leebyron
force-pushed
the
real-module
branch
from
7fc5f13
to
2c8caac
Compare
jest now has a main file which only exports. It also has bin/jest which consumes itself as a module. This results in bin/jest being much smaller and easier to understand. It's now only responsible for finding the appropriate jest module and running it's runCLI method. src/jest now only exports things. It exports runCLI, as it did before, but also exports TestRunner directly, should someone wish to operate jest without CLI (an important first step to running jest in a browser for browser CI testing). the runCLI method has been simplified by moving it's steps into separate functions, reducing duplicated logic and making the chain of events a bit easier to follow.
leebyron
force-pushed
the
real-module
branch
from
2c8caac
to
da20dbe
Compare
|
nice! will this support building the internal cli with? |
|
Working on that next. Should improve the custom CLIs. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is dependent on #170, #171, #172. Check out da20dbe for a clearer read.
Jest now has a main file which only exports. It also has bin/jest which only executes and consumes itself as a module.