Remove jasmine dependency from jest-matchers #2389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,239 @@ | |||
| /** | |||
| * Copyright (c) 2014, Facebook, Inc. All rights reserved. | |||
There was a problem hiding this comment.
should it be jasmine's copyright though?
There was a problem hiding this comment.
Whoops, changed to jasmine copyright
|
❤️ |
vjeux
force-pushed
the
remove_jasmine_dep
branch
from
6691b2e
to
ffc9b48
Compare
I brought equals from the checked in version of jasmine ( https://github.com/facebook/jest/blob/db0f3b4902ddb360020be8f737db1fae7a8508c4/packages/jest-jasmine2/vendor/jasmine-2.5.2.js#L2787-L3048 ) I did a few tweaks: - Imported isUndefined, isA and isDomNode - Moved all the functions that were defined inside of functions to the global "namespace" - Disabled lint and flow
vjeux
force-pushed
the
remove_jasmine_dep
branch
from
ffc9b48
to
7b622b0
Compare
vjeux
added a commit
to vjeux/jest
that referenced
this pull request
Dec 20, 2016
In jestjs#2389 I moved equals but it turns out there are more! I renamed the file `expect.js` to `jasmine-utils` and moved it to `jest-matchers` instead of `jest-matcher-utils`. This is the big thing, otherwise it's been pretty much copy and pasted from jasmine.
vjeux
added a commit
to vjeux/jest
that referenced
this pull request
Dec 20, 2016
In jestjs#2389 I moved equals but it turns out there are more! I renamed the file `expect.js` to `jasmine-utils` and moved it to `jest-matchers` instead of `jest-matcher-utils`. This is the big thing, otherwise it's been pretty much copy and pasted from jasmine.
vjeux
added a commit
to vjeux/jest
that referenced
this pull request
Dec 20, 2016
In jestjs#2389 I moved equals but it turns out there are more! I renamed the file `expect.js` to `jasmine-utils` and moved it to `jest-matchers` instead of `jest-matcher-utils`. This is the big thing, otherwise it's been pretty much copy and pasted from jasmine.
cpojer
pushed a commit
that referenced
this pull request
Dec 21, 2016
In #2389 I moved equals but it turns out there are more! I renamed the file `expect.js` to `jasmine-utils` and moved it to `jest-matchers` instead of `jest-matcher-utils`. This is the big thing, otherwise it's been pretty much copy and pasted from jasmine.
aaronabramov
pushed a commit
to aaronabramov/jest
that referenced
this pull request
Dec 22, 2016
I brought equals from the checked in version of jasmine ( https://github.com/facebook/jest/blob/db0f3b4902ddb360020be8f737db1fae7a8508c4/packages/jest-jasmine2/vendor/jasmine-2.5.2.js#L2787-L3048 ) I did a few tweaks: - Imported isUndefined, isA and isDomNode - Moved all the functions that were defined inside of functions to the global "namespace" - Disabled lint and flow
aaronabramov
pushed a commit
to aaronabramov/jest
that referenced
this pull request
Dec 22, 2016
In jestjs#2389 I moved equals but it turns out there are more! I renamed the file `expect.js` to `jasmine-utils` and moved it to `jest-matchers` instead of `jest-matcher-utils`. This is the big thing, otherwise it's been pretty much copy and pasted from jasmine.
skovhus
pushed a commit
to skovhus/jest
that referenced
this pull request
Apr 29, 2017
I brought equals from the checked in version of jasmine ( https://github.com/facebook/jest/blob/db0f3b4902ddb360020be8f737db1fae7a8508c4/packages/jest-jasmine2/vendor/jasmine-2.5.2.js#L2787-L3048 ) I did a few tweaks: - Imported isUndefined, isA and isDomNode - Moved all the functions that were defined inside of functions to the global "namespace" - Disabled lint and flow
skovhus
pushed a commit
to skovhus/jest
that referenced
this pull request
Apr 29, 2017
In jestjs#2389 I moved equals but it turns out there are more! I renamed the file `expect.js` to `jasmine-utils` and moved it to `jest-matchers` instead of `jest-matcher-utils`. This is the big thing, otherwise it's been pretty much copy and pasted from jasmine.
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
I brought equals from the checked in version of jasmine ( https://github.com/facebook/jest/blob/db0f3b4902ddb360020be8f737db1fae7a8508c4/packages/jest-jasmine2/vendor/jasmine-2.5.2.js#L2787-L3048 ) I did a few tweaks: - Imported isUndefined, isA and isDomNode - Moved all the functions that were defined inside of functions to the global "namespace" - Disabled lint and flow
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
In jestjs#2389 I moved equals but it turns out there are more! I renamed the file `expect.js` to `jasmine-utils` and moved it to `jest-matchers` instead of `jest-matcher-utils`. This is the big thing, otherwise it's been pretty much copy and pasted from jasmine.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I brought equals from the checked in version of jasmine ( https://github.com/facebook/jest/blob/db0f3b4902ddb360020be8f737db1fae7a8508c4/packages/jest-jasmine2/vendor/jasmine-2.5.2.js#L2787-L3048 )
I did a few tweaks: