-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jest-resolve] Use is-builtin-module
instead of resolve.isCore
.
#2997
Merged
cpojer
merged 3 commits into
jestjs:master
from
wtgtybhertgeghgtwtg:use-is-builtin-module
Feb 24, 2017
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
/** | ||
* Copyright (c) 2014-present, Facebook, Inc. All rights reserved. | ||
* | ||
* This source code is licensed under the BSD-style license found in the | ||
* LICENSE file in the root directory of this source tree. An additional grant | ||
* of patent rights can be found in the PATENTS file in the same directory. | ||
* | ||
* @emails oncall+jsinfra | ||
*/ | ||
|
||
'use strict'; | ||
|
||
const ModuleMap = require('jest-haste-map').ModuleMap; | ||
const Resolver = require('../'); | ||
|
||
describe('isCoreModule', () => { | ||
it('returns false if `hasCoreModules` is false.', () => { | ||
const moduleMap = new ModuleMap(); | ||
const resolver = new Resolver(moduleMap, { | ||
browser: false, | ||
hasCoreModules: false, | ||
}); | ||
const isCore = resolver.isCoreModule('assert'); | ||
expect(isCore).toEqual(false); | ||
}); | ||
|
||
it('returns true if `hasCoreModules` is false and `moduleName` is a core module.', () => { | ||
const moduleMap = new ModuleMap(); | ||
const resolver = new Resolver(moduleMap, { | ||
browser: false, | ||
}); | ||
const isCore = resolver.isCoreModule('assert'); | ||
expect(isCore).toEqual(true); | ||
}); | ||
|
||
it('returns false if `hasCoreModules` is false and `moduleName` is not a core module.', () => { | ||
const moduleMap = new ModuleMap(); | ||
const resolver = new Resolver(moduleMap, { | ||
browser: false, | ||
}); | ||
const isCore = resolver.isCoreModule('not-a-core-module'); | ||
expect(isCore).toEqual(false); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, this doesn't make sense.
hasCoreModules
is true, it should return true if you pass in a core module. If it is false, it should return false when passing in a core module.hasCoreModule
is true, it should return false if you pass in a non-core module. If it is false, it should always return false.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't that what it is doing? Should I have a test for
hasCoreModule: false
andisCore('non-core-module')
?