Update babylon plugins in BabylonParser, solves #3070 #3076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work! Thanks. |
|
The changes were not published. The 19.0.2 version still has old code: |
This was referenced Apr 21, 2017
skovhus
pushed a commit
to skovhus/jest
that referenced
this pull request
Apr 29, 2017
) * change babylon plugins to all, fixes jestjs#3070 * increase minimum required babylon version for new features to work
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
) * change babylon plugins to all, fixes jestjs#3070 * increase minimum required babylon version for new features to work
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Solves #3070. Instead of including only the 'flow' babylon plugin, all available babylon plugins are included. As a result, parsing files containing JSX does not produce an error.
Test plan
Added a test case to
fixtures/global_its.exampleandfixtures/global_its.example. The test checks whether parsing works with JSX:This test wouldn't pass without the change. It does pass with the change.