Optional jasmine 2 support

[akhomchenko]

Good day.

This patch adds optional jasmine 2.x support to jest.

Benefits:

• bundled jasmine is not modified, it can be updated any time
• done callback support
• whatever you need from jasmine-2.x

TODOs:

• make Add support for jasmine 2.2.x jeffmo/jasmine-pit#12 work, so I can remove dependency on my fork of jasmine-pit
• extract base code for both runners
• update matchers as I haven't tested them after update
• fix all TODO's
• add note about jasmine 1.x and jasmine 2.x differences

Patches are welcome.

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[rayshan]

+1

[kjs3]

+1
Where does this stand?

[tomv564]

@gagoman: there is a new pull request against your fork with some contributions for the open issues. Please check.

[cpojer]

Alright, I finally got around to spend time on this. This looks really good, @gagoman would you mind rebasing this on top of master before we continue? I'm sorry for causing this pain :(

[DaleLJefferson]

@gagoman Based on what @cpojer has said, should we look at removing Jasmine 1 and using Jasmine 2 exclusively. Let me know if you need any help.

[cpojer]

I think it is fine to add jasmine 2 support as an option. I'll think about the deprecation strategy for jasmine 1 later and when it makes sense to make jasmine 2 the default. Ideally we'll support any kind of test framework within jest in the future and we can split jasmine1 support out into a separate npm package.

[akhomchenko]

@cpojer ok, I'll rebase it in a next few days

[cpojer]

@gagoman did you get a chance to work on this? :)

[akhomchenko]

@cpojer I'm working on this. A lot of things changed in jest since this PR was created.

[akhomchenko]

@cpojer Done. Please review, as I can forgot something, especially new additions to reporters.

As for now I see one missing part:

• noStackTraces in jasmine 2 Reporter

[cpojer]

@gagoman thank you so much! I'll take a look in a bit. I'm hoping to merge this for the December release with the new resolve (jest 0.8.0).

[cpojer]

Ok, as a first step I'm elevating jasmine-pit into the jest repo. There is no point in keeping it in a separate repo. Going to get code-review for this and push it out.

I need to figure out how to deal with your diff. I'd like to make some changes to your pull request but I want the sync script to properly attribute you for your diff. I might merge your diff internally and make my changes in a separate diff. Thanks for all the hard work and I'm deeply sorry that it took forever for someone at FB to take a look at this. This is not ok and will not happen again.

If you want to hang out with me and other people using jest online, feel free to join our channel on discord: http://facebook.github.io/jest/support.html :)

[cpojer]

@facebook-github-bot import

[facebook-github-bot]

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1663907390495818/int_phab to review.

[cpojer]

Awesome. This almost works internally. I have a couple of small modifications to your diff and will make a cleanup diff afterwards to make all of this fit into jest better. I'll try to land all of this tomorrow.

[akhomchenko]

@cpojer As for: Error: foo, case is API compatibility. So quick example:

it('should throw', function () {
    expect(function() {
      throw new Error('foo');
    }).toThrow('foo');
});

Will pass on Jasmine 1.x, but will fail on Jasmine 2.x with: Expected function to throw 'foo', but it threw Error: foo.

While:

it('should throw', function () {
  expect(function() {
    throw new Error('foo');
  }).toThrow(new Error('foo'));
});

Will pass on both versions.

Jasmine 2.x has toThrowError which is working with string, but Jasmine 1.x has no.

[cpojer]

Yeah it seems like there is something else going on internally that is unrelated to your changes.

[akhomchenko]

Can I help with any tasks related to this?

[cpojer]

Nope, I'm almost done! Going to merge it tomorrow when I get up.

[cpojer]

It's happening!

@gagoman thank you for your contribution. I'm deeply sorry it took so long for this to get merged. I have taken your implementation and polished it up a little bit in a follow-up.

[cpojer]

This is really annoying. Our FB GitHub bot picked one user in this PR to give attribution to because it flattens everything into one commit. @gagoman if you'll accept I would like to send you a ReactJS tshirt as a thank you for pushing this change through for this entire time. Send your tshirt size, name and address to [email protected]. I'm going to be out of the office for the next 12 days but I'll make sure that you receive this by the end of the year.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.